Title
sub_match::swap only swaps the base class
Status
new
Section
[re.submatch]
Submitter
Jonathan Wakely

Created on 2019-05-07.00:00:00, last changed 2019-06-10.05:16:56.

Messages

Date: 2019-06-10.05:16:56

Proposed resolution:

This wording is relative to N4810.

  1. Modify [re.submatch], class template sub_match synopsis, as indicated:

    template<class BidirectionalIterator>
    class sub_match : public pair<BidirectionalIterator, BidirectionalIterator> {
    public:
      […]
      int compare(const sub_match& s) const;
      int compare(const string_type& s) const;
      int compare(const value_type* s) const;
      
      void swap(sub_match& s) noexcept(see below);
    };
    
  2. Modify [re.submatch.members] as indicated:

    int compare(const value_type* s) const;
    

    […]

    void swap(sub_match& s) noexcept(see below);
    
    [Drafting note: The swappable requirement should really be unnecessary because Cpp17Iterator requires it, but there is no wording that requires BidirectionalIterator to satisfy the bidirectional iterator requirements. — end drafting note]

    -?- Expects: Lvalues of type BidirectionalIterator are swappable ([swappable.requirements]).

    -?- Effects: Equivalent to:

    this->pair<BidirectionalIterator, BidirectionalIterator>::swap(s);
    std::swap(matched, s.matched);
    

    -?- Remarks: The expression inside noexcept is equivalent to is_nothrow_swappable_v<BidirectionalIterator>.

Date: 2019-06-12.00:00:00

[ 2019-06-12 Priority set to 3 after reflector discussion ]

Date: 2019-05-07.00:00:00

sub_match<I> derives publicly from pair<I,I>, and so inherits pair::swap(pair&). This means that the following program fails:

#include <regex>
#include <cassert>

int main()
{
  std::sub_match<const char*> a, b;
  a.matched = true;
  a.swap(b);
  assert(b.matched);
}

The pair::swap(pair&) member should be hidden by a sub_match::swap(sub_match&) member that does the right thing.

History
Date User Action Args
2019-06-10 05:16:56adminsetmessages: + msg10434
2019-05-11 13:27:56adminsetmessages: + msg10403
2019-05-07 00:00:00admincreate