Title
sub_match::swap only swaps the base class
Status
ready
Section
[re.submatch]
Submitter
Jonathan Wakely

Created on 2019-05-07.00:00:00 last changed 6 days ago

Messages

Date: 2022-11-30.09:50:57

Proposed resolution:

This wording is relative to N4917 and assumes the acceptance of P2696R0.

  1. Modify [re.submatch], class template sub_match synopsis, as indicated:

    template<class BidirectionalIterator>
    class sub_match : public pair<BidirectionalIterator, BidirectionalIterator> {
    public:
      […]
      int compare(const sub_match& s) const;
      int compare(const string_type& s) const;
      int compare(const value_type* s) const;
      
      void swap(sub_match& s) noexcept(see below);
    };
    
  2. Modify [re.submatch.members] as indicated:

    int compare(const value_type* s) const;
    

    […]

    void swap(sub_match& s) noexcept(see below);
    
    [Drafting note: The Cpp17Swappable requirement should really be unnecessary because Cpp17Iterator requires it, but there is no wording that requires BidirectionalIterator in Clause [re] in general meets the bidirectional iterator requirements. Note that the definition found in [algorithms.requirements] does not extend to [re] normatively. — end drafting note]

    -?- Preconditions: BidirectionalIterator meets the Cpp17Swappable requirements ([swappable.requirements]).

    -?- Effects: Equivalent to:

    this->pair<BidirectionalIterator, BidirectionalIterator>::swap(s);
    std::swap(matched, s.matched);
    

    -?- Remarks: The exception specification is equivalent to is_nothrow_swappable_v<BidirectionalIterator>.

Date: 2022-11-15.00:00:00

[ 2022-11-30; Reflector poll ]

Set status to Tentatively Ready after six votes in favour during reflector poll.

Date: 2022-11-15.00:00:00

[ 2022-11-06; Daniel comments and improves wording ]

With the informal acceptance of P2696R0 by LWG during a pre-Kona telecon, we should use the new requirement set Cpp17Swappable instead of the "LValues are swappable" requirements.

Date: 2022-04-15.00:00:00

[ 2022-04-25; Daniel adjusts wording to recent working draft ]

In addition the revised wording uses the new standard phrase "The exception specification is equivalent to"

Previous resolution [SUPERSEDED]:

This wording is relative to N4910.

  1. Modify [re.submatch], class template sub_match synopsis, as indicated:

    template<class BidirectionalIterator>
    class sub_match : public pair<BidirectionalIterator, BidirectionalIterator> {
    public:
      […]
      int compare(const sub_match& s) const;
      int compare(const string_type& s) const;
      int compare(const value_type* s) const;
      
      void swap(sub_match& s) noexcept(see below);
    };
    
  2. Modify [re.submatch.members] as indicated:

    int compare(const value_type* s) const;
    

    […]

    void swap(sub_match& s) noexcept(see below);
    
    [Drafting note: The swappable requirement should really be unnecessary because Cpp17Iterator requires it, but there is no wording that requires BidirectionalIterator in Clause [re] in general meets the bidirectional iterator requirements. Note that the definition found in [algorithms.requirements] does not extend to [re] normatively. — end drafting note]

    -?- Preconditions: Lvalues of type BidirectionalIterator are swappable ([swappable.requirements]).

    -?- Effects: Equivalent to:

    this->pair<BidirectionalIterator, BidirectionalIterator>::swap(s);
    std::swap(matched, s.matched);
    

    -?- Remarks: The exception specification is equivalent to is_nothrow_swappable_v<BidirectionalIterator>.

Date: 2020-05-15.00:00:00

[ 2020-05-01; Daniel adjusts wording to recent working draft ]

Date: 2019-06-12.00:00:00

[ 2019-06-12 Priority set to 3 after reflector discussion ]

Date: 2019-05-07.00:00:00

sub_match<I> derives publicly from pair<I,I>, and so inherits pair::swap(pair&). This means that the following program fails:

#include <regex>
#include <cassert>

int main()
{
  std::sub_match<const char*> a, b;
  a.matched = true;
  a.swap(b);
  assert(b.matched);
}

The pair::swap(pair&) member should be hidden by a sub_match::swap(sub_match&) member that does the right thing.

History
Date User Action Args
2022-11-30 09:50:57adminsetmessages: + msg13123
2022-11-30 09:50:57adminsetstatus: new -> ready
2022-11-06 12:07:45adminsetmessages: + msg12937
2022-04-25 12:14:13adminsetmessages: + msg12433
2020-05-01 18:40:29adminsetmessages: + msg11248
2019-06-10 05:16:56adminsetmessages: + msg10434
2019-05-11 13:27:56adminsetmessages: + msg10403
2019-05-07 00:00:00admincreate